Write FLAC STREAMINFO MD5 checksum#906
Merged
Merged
Conversation
Signed-off-by: Patryk Miś <foss@patrykmis.com>
Signed-off-by: Andrew Gunnerson <accounts+github@chiller3.com>
chenxiaolong
approved these changes
Jul 3, 2026
chenxiaolong
left a comment
chenxiaolong
left a comment
Owner
There was a problem hiding this comment.
Thanks!
I've added one extra commit (1c315cd) to remove the unused FlacContainer.lastPresentationTimeUs, but otherwise, this looks good to me.
chenxiaolong
added a commit
that referenced
this pull request
Jul 3, 2026
Signed-off-by: Andrew Gunnerson <accounts+github@chiller3.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the FLAC container finalization path to write the STREAMINFO MD5 checksum of the unencoded PCM audio data, as specified by FLAC.
The implementation adds a small optional hook for containers that need metadata derived from encoder input samples.
FlacContaineruses it to track the exact interchannel sample count and MD5 digest of the same PCM bytes submitted toMediaCodec.This keeps the existing crash-resilient behavior: encoded FLAC frames are still written to disk as they are produced, and the STREAMINFO patch is only a finalization step for cleanly closed recordings.
It also replaces the previous EOF presentation timestamp based duration calculation with an exact sample count derived from the PCM input, avoiding small rounding/under-counting errors in the STREAMINFO total samples field.